]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
windowManager: Undim parent when minimizing attached modal
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 16 Jun 2022 20:35:56 +0000 (22:35 +0200)
committerMarge Bot <marge-bot@gnome.org>
Tue, 21 Jun 2022 22:06:01 +0000 (22:06 +0000)
Minimizing modal dialogs is highly unconventional - and in fact
disabled in our own code - but apps can still do it programmatically.

The parent window shouldn't remain dimmed in that case, so make
sure to re-check dimming when minimizing an attached modal.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5581

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2337>

js/ui/windowManager.js

index bd47e6e5d562deee71d4fa3ce29493043e57cce9..166480db850340887b601d9297d1697606853e97 100644 (file)
@@ -1141,6 +1141,10 @@ var WindowManager = class {
     }
 
     _minimizeWindow(shellwm, actor) {
+        const window = actor.meta_window;
+        if (window.is_attached_dialog())
+            this._checkDimming(window.get_transient_for());
+
         const types = [
             Meta.WindowType.NORMAL,
             Meta.WindowType.MODAL_DIALOG,